Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.5.x] Bump version to 1.5.1#16072

Merged
TaoLv merged 1 commit intoapache:v1.5.xfrom
TaoLv:v1.5.1-version
Sep 4, 2019
Merged

[v1.5.x] Bump version to 1.5.1#16072
TaoLv merged 1 commit intoapache:v1.5.xfrom
TaoLv:v1.5.1-version

Conversation

@TaoLv
Copy link
Copy Markdown
Member

@TaoLv TaoLv commented Sep 2, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@TaoLv
Copy link
Copy Markdown
Member Author

TaoLv commented Sep 2, 2019

@szha @aaronmarkham @lanking520 @gigasquid @iblis17 Please help to review. Thanks!

@TaoLv
Copy link
Copy Markdown
Member Author

TaoLv commented Sep 2, 2019

@lanking520 I'm not familiar with Scala package but I notice in scala-package/core/src/main/scala/org/apache/mxnet/NDArrayCollector.scala, there are some version strings fixed to 1.5.0. Do you think they need be bumped to 1.5.1 also?

ChaiBapchya
ChaiBapchya approved these changes Sep 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for leading this release!

samskalicky
samskalicky approved these changes Sep 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@samskalicky samskalicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaoLv
Copy link
Copy Markdown
Member Author

TaoLv commented Sep 4, 2019

Thanks for your kind review @ChaiBapchya @samskalicky. Merging now.

@TaoLv TaoLv merged commit c981848 into apache:v1.5.x Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290 anirudh2290 is a code owner

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin eric-haibin-lin is a code owner

@gigasquid gigasquid Awaiting requested review from gigasquid gigasquid is a code owner

@iblislin iblislin Awaiting requested review from iblislin

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

2 more reviewers

@samskalicky samskalicky samskalicky approved these changes

@ChaiBapchya ChaiBapchya ChaiBapchya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TaoLv @samskalicky @ChaiBapchya