Skip to content

feat(asr): add optional auxiliary timestamp model restoration for Canary#15268

Merged
nithinraok merged 1 commit intoNVIDIA-NeMo:mainfrom
chaosido:fix/optional-timestamp-model
Jan 8, 2026
Merged

feat(asr): add optional auxiliary timestamp model restoration for Canary#15268
nithinraok merged 1 commit intoNVIDIA-NeMo:mainfrom
chaosido:fix/optional-timestamp-model

Conversation

@chaosido
Copy link
Copy Markdown
Contributor

@chaosido chaosido commented Jan 7, 2026

What does this PR do ?

This PR adds an optional restore_timestamps_model configuration to EncDecMultiTaskModel (Canary). This allows users to disable the automatic restoration of the auxiliary timestamp model (approx. 4GB VRAM) during finetuning/training,

Collection: ASR

Changelog

  • Added restore_timestamps_model check in EncDecMultiTaskModel.__init__.
  • Skips loading timestamps_asr_model if config flag is False.

Usage

model:
  restore_timestamps_model: False

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Who can review?

@titu1994, @redoctopus, @jbalam-nv, @okuchaiev (ASR Collection)

@github-actions github-actions Bot added the ASR label Jan 7, 2026
Signed-off-by: chaosido <wonnink.jesse@gmail.com>
@chaosido chaosido force-pushed the fix/optional-timestamp-model branch from 7626812 to 3b3b9a2 Compare January 7, 2026 10:08
@nithinraok
Copy link
Copy Markdown
Member

Thanks @chaosido for the PR.

We have another PR incoming to improve memory consumption and loading time for canary-v2 models.

Copy link
Copy Markdown
Member

@nithinraok nithinraok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nithinraok nithinraok enabled auto-merge (squash) January 7, 2026 17:16
@nithinraok nithinraok merged commit ab5fabc into NVIDIA-NeMo:main Jan 8, 2026
164 of 166 checks passed
AkCodes23 pushed a commit to AkCodes23/NeMo that referenced this pull request Jan 28, 2026
…ary (NVIDIA-NeMo#15268)

Signed-off-by: chaosido <wonnink.jesse@gmail.com>
Signed-off-by: Akhil Varanasi <akhilvaranasi23@gmail.com>
nune-tadevosyan pushed a commit to nune-tadevosyan/NeMo that referenced this pull request Mar 13, 2026
…ary (NVIDIA-NeMo#15268)

Signed-off-by: chaosido <wonnink.jesse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants