Skip to content

set dynamo=False to support latest version of pytorch#15284

Merged
chtruong814 merged 1 commit intomainfrom
fix_export_issues_with_lstm
Jan 11, 2026
Merged

set dynamo=False to support latest version of pytorch#15284
chtruong814 merged 1 commit intomainfrom
fix_export_issues_with_lstm

Conversation

@nithinraok
Copy link
Copy Markdown
Member

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Fix Onnx ASR models export

Collection: ASR

Changelog

  • In PyTorch 2.5+, torch.onnx.export() defaults to using the new dynamo-based exporter, which has issues with LSTM modules.

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

[🤖]: Hi @nithinraok 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@chtruong814 chtruong814 merged commit b7fadf0 into main Jan 11, 2026
295 of 300 checks passed
@chtruong814 chtruong814 deleted the fix_export_issues_with_lstm branch January 11, 2026 15:52
rfejgin pushed a commit to rfejgin/NeMo that referenced this pull request Jan 13, 2026
)

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
AkCodes23 pushed a commit to AkCodes23/NeMo that referenced this pull request Jan 28, 2026
)

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: Akhil Varanasi <akhilvaranasi23@gmail.com>
nune-tadevosyan pushed a commit to nune-tadevosyan/NeMo that referenced this pull request Mar 13, 2026
)

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Changes to NeMo Core skip-linting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants