Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

documentation enhancement for optimizers#11657

Merged
szha merged 5 commits intoapache:masterfrom
eric-haibin-lin:doc-optim
Jul 12, 2018
Merged

documentation enhancement for optimizers#11657
szha merged 5 commits intoapache:masterfrom
eric-haibin-lin:doc-optim

Conversation

@eric-haibin-lin
Copy link
Copy Markdown
Member

@eric-haibin-lin eric-haibin-lin commented Jul 11, 2018

Description

Added more clarification for optimizers

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

szha
szha reviewed Jul 12, 2018
View reviewed changes
Comment thread docs/tutorials/sparse/row_sparse.md
and [mxnet.optimizer.Adam](https://mxnet.incubator.apache.org/api/python/optimization/optimization.html#mxnet.optimizer.Adam) support sparse updates in MXNet.
Note that only [mxnet.optimizer.SGD](https://mxnet.incubator.apache.org/api/python/optimization/optimization.html#mxnet.optimizer.SGD)
and [mxnet.optimizer.Adam](https://mxnet.incubator.apache.org/api/python/optimization/optimization.html#mxnet.optimizer.Adam) and
[mxnet.optimizer.AdaGrad](https://mxnet.incubator.apache.org/api/python/optimization/optimization.html#mxnet.optimizer.AdaGrad) support sparse updates in MXNet.
Copy link
Copy Markdown
Member

@szha szha Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider writing it as "a, b, and c" instead of "a and b and c" for three items

@szha szha merged commit 2fd7085 into apache:master Jul 12, 2018
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
@eric-haibin-lin @szha
documentation enhancement for optimizers (apache#11657)
b759c7b 
* update tutorial

* add doc for clarification;

* add docs for gluon blocks

* Update row_sparse.md

* Update row_sparse.md
@eric-haibin-lin eric-haibin-lin deleted the doc-optim branch September 18, 2018 23:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290

1 more reviewer

@szha szha szha left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eric-haibin-lin @szha